[WIP] Optimise User Tag Map Mod to improve startup

Discussion in 'Work-In-Progress Mods' started by mikeyh, September 8, 2014.

  1. mikeyh

    mikeyh Post Master General

    Messages:
    1,869
    Likes Received:
    1,509
    If you did a semi-manual install then remove those copies and install the automatic PAMM versions.
  2. domii894

    domii894 New Member

    Messages:
    12
    Likes Received:
    1
    Ok thanks :)
  3. mikeyh

    mikeyh Post Master General

    Messages:
    1,869
    Likes Received:
    1,509
  4. rayzone12

    rayzone12 New Member

    Messages:
    27
    Likes Received:
    1
    question is this for all of PA game, BECAUSE... GW is online too...????
  5. mikeyh

    mikeyh Post Master General

    Messages:
    1,869
    Likes Received:
    1,509
    Optimise User Tag Map has been updated for 76766 and PTE 76843.

    My user tag map had grown to 915 and is now back to a manageable 45.
  6. ViolentMind

    ViolentMind Active Member

    Messages:
    394
    Likes Received:
    186
    Would you be able to move the button for this one back over to the left side of the screen? Now that Cola_Colin added halcyon (Global chat via PAStats), it seems that Optimise User Tag Map moves the friends and the Notifications buttons under that chat window, so they are no longer selectable. If it is enabled, then all that you can see is the time.

    Enabled:
    upload_2015-1-31_15-32-11.png

    Disabled:
    upload_2015-1-31_15-35-51.png
    cola_colin likes this.
  7. cola_colin

    cola_colin Moderator Alumni

    Messages:
    12,074
    Likes Received:
    16,221
    on the issue of "it requests so many users at startup", @Sekuraz and myself just noticed a bug in the caching of the displaynames that is causing this:
    In uberbar.js it loads the displayname from the cached map:

    [​IMG]

    and then it tests "Do I have that name? If not query it..." Notice what exactly hasName returns ... it is missing a return. It seems it was supposed to do return self.displayName() !== undefined or similar.
    [​IMG]

    @jorgenpt this is really easy to fix
    ViolentMind, proeleert and Quitch like this.
  8. masterdigital

    masterdigital Uber Alumni

    Messages:
    438
    Likes Received:
    833
    Not sure what you mean with the second edit.
  9. cola_colin

    cola_colin Moderator Alumni

    Messages:
    12,074
    Likes Received:
    16,221
    There is not edit of the post. If you mean the red arrow it simply is there to show that because hasName() is always undefined the if (!self.hasName()) will always be executed and thus the code will follow the red arrow into the call to ubernet for every UserModel that is created.
    So the only thing that needs fixing is the definition of hasName so it actually returns true or false and not just always undefined.
  10. mikeyh

    mikeyh Post Master General

    Messages:
    1,869
    Likes Received:
    1,509
    Moved.
    ViolentMind and Quitch like this.
  11. elvisior

    elvisior Member

    Messages:
    85
    Likes Received:
    21
    Has this been fixed?
  12. cola_colin

    cola_colin Moderator Alumni

    Messages:
    12,074
    Likes Received:
    16,221
    the PTE fixes the bug I mentioned above. That should prevent the issue. Question is: Will name updates still be pushed correctly or will names go stale?
  13. mikeyh

    mikeyh Post Master General

    Messages:
    1,869
    Likes Received:
    1,509
  14. frostyrootbeer

    frostyrootbeer New Member

    Messages:
    26
    Likes Received:
    5
    i'm stupid, what does this do in laymans terms?
  15. mikeyh

    mikeyh Post Master General

    Messages:
    1,869
    Likes Received:
    1,509
    Install the mod and check the number in the button.

    If you play a lot of games the number could be in the thousands and includes your friends and every user you have seen over time.

    The higher the number the slower your startup times will be loading display names for all those users.

    Click the button.
  16. lulamae

    lulamae Planetary Moderator

    Messages:
    798
    Likes Received:
    307
    Is this still functional? I no longer see the button/numbers. I've uninstalled and reinstalled.
  17. mikeyh

    mikeyh Post Master General

    Messages:
    1,869
    Likes Received:
    1,509
    It's automatic and included in the PA Chat and PA Stats mods.
  18. lulamae

    lulamae Planetary Moderator

    Messages:
    798
    Likes Received:
    307

Share This Page