[REL] "Advanced" Planet Details [71379]

Discussion in 'Mod Discussions' started by Dementiurge, November 28, 2013.

  1. jpinard

    jpinard Member

    Messages:
    75
    Likes Received:
    22
    Will this work with the metal count mod: "Better System View"?
  2. Dementiurge

    Dementiurge Post Master General

    Messages:
    1,094
    Likes Received:
    693
    Uploaded v2.1b, should fix the resolution issue. Also added a close button -- I've always wanted one.

    They're in completely different scenes. Better System View is for the In-game UI, APD is for the pre-game lobby, so they can't possibly conflict.

    That said, this mod doesn't tell you the metal deposits on a planet (I don't believe that number is exposed until you're in-game). The 'Metal Clusters' variable is actually an internal number from the system designer, and I don't know what it does exactly. In v2.1b I've added a % sign so no one should think it's the actual number of metal deposits.
    mishtakashi likes this.
  3. shiwanabe

    shiwanabe Member

    Messages:
    82
    Likes Received:
    32
    You'll want to show both Density and Clusters as both affect the metal amounts. Scathis just explained it over in the main forum.


    I do find it's a bit weird, but that's apparently how they do/did it.
  4. zgrssd

    zgrssd Active Member

    Messages:
    658
    Likes Received:
    185
    I think this mod is causing a bug in my game lobby. I manage mods with the Atom Shell Variant of PAMM.

    When I have your mod enabeled this happens to my lobby screen:
    2014-09-12_00002.jpg

    I cannot click on anything. Especially not the leave button. I have to quit via Alt+F4.

    It happens when yours is the only mod enabeled and it does not happen if every the mods but yours is enabeled, so I think there is no problem with interaction.

    Here is my ui_mods_list.js with only your mod enabeled:
    Hope you can fix it.
  5. jpinard

    jpinard Member

    Messages:
    75
    Likes Received:
    22
    I have massive bugs with this mod too.
  6. Dementiurge

    Dementiurge Post Master General

    Messages:
    1,094
    Likes Received:
    693
    Fixed in 2.1c.
    Even updated on PAMM.
    mishtakashi and Fr33Lancer like this.
  7. zgrssd

    zgrssd Active Member

    Messages:
    658
    Likes Received:
    185
    Jupp, works like a charm now.

    First time I klicked on details I got thrown back to main menu (I instead landed on the multiplayer lobby when I was on singlepalyer lobby before).
    But this is propably unrelated.
  8. stawos

    stawos Member

    Messages:
    79
    Likes Received:
    46
    Awesome! Glad this is working again in current build. but for some reason, I can't bring up details unless I'm the host. The button isn't there if I join someone else's game
  9. stuart98

    stuart98 Post Master General

    Messages:
    6,009
    Likes Received:
    3,888
    Confirmed. The details button only shows up for the host.
  10. yarmond

    yarmond Member

    Messages:
    23
    Likes Received:
    50
    To make the "Details" button work correctly for all clients, at the bottom of apd_newgame.js change:
    Code:
    $("#system .system-controls").append(showDetailsButton);
    to:
    Code:
    if ($('.system-controls').length) {
        $("#system .system-controls").append(showDetailsButton);
    } else {
        $(".game_system").append(showDetailsButton);
    }
    
    stuart98 and stawos like this.
  11. stawos

    stawos Member

    Messages:
    79
    Likes Received:
    46
    THANK YOU! Gonna test it asap! been waiting for this :)
  12. Quitch

    Quitch Post Master General

    Messages:
    5,863
    Likes Received:
    6,045
    This will need updating when the new PTE goes live. The system display has been changed.
  13. Dementiurge

    Dementiurge Post Master General

    Messages:
    1,094
    Likes Received:
    693
    You aren't kidding!

    Did it work?
  14. stawos

    stawos Member

    Messages:
    79
    Likes Received:
    46
    even replacing the text, I couldn't get the button to show up. :/
  15. yarmond

    yarmond Member

    Messages:
    23
    Likes Received:
    50
    Yep, this was broken again by the latest patch. Using this chunk near the end of apd_newgame.js should fix it again:
    Code:
    showDetailsButtonHost = '<div class="btn_std_gray" data-bind="click: apd.toggleDetailPanel"><div class="btn_std_label">Details</div></div>';
    showDetailsButtonClient = '<div class="btn_std_gray" data-bind="click: apd.toggleDetailPanel, visible: !model.isGameCreator()"><div class="btn_std_label">Details</div></div>';
    
    if ("system" in model) {
        $(".section_content_table").first().prepend(newPlanetTable);
        $("#system .system-controls").append(showDetailsButtonHost);
        $(".section.game_system").append(showDetailsButtonClient);
    };
    
  16. Dementiurge

    Dementiurge Post Master General

    Messages:
    1,094
    Likes Received:
    693
    Pushed out an update to PAMM that should be able to handle the system picker in the PTE. (At least I think I did.)
    Didn't test it as a non host so I'm not sure if the code changes have affected that problem.
    mishtakashi and ViolentMind like this.
  17. stawos

    stawos Member

    Messages:
    79
    Likes Received:
    46
    Just joined a game on stable and it works perfectly (non host) :)
  18. stawos

    stawos Member

    Messages:
    79
    Likes Received:
    46
    The details button breaks planet generation in the lobby on new build. :(
  19. Dementiurge

    Dementiurge Post Master General

    Messages:
    1,094
    Likes Received:
    693
    Any more info on why/how this happens? I can switch systems in an AI skirmish lobby without issues.
  20. yarmond

    yarmond Member

    Messages:
    23
    Likes Received:
    50
    The only issue I'm having right now seems to be related to the use of the unquoted string metal_spots which appears in a couple of places (once in apd.planetIsCustom and once in the HTML blob of newPlanetTable, both in apd_newgame.js, although the former never seems to be called).
  21. trilioth

    trilioth Member

    Messages:
    93
    Likes Received:
    36
    It's seems this mod is bugged with the current version.

    screenshot

Share This Page