I just verified that none of our jsons were invalid; everything works as it should. I'll see if I can figure out what's causing the invalid commander spec. Our mod includes the old json for Xenosentryprime in the unitlist.json. If you removed that json file then I'd imagine things could break.
Okay, looks like you guys added a bunch of crap that we're missing to the commander jsons. Gonna be a fun hour I'll spend fixing that. EDIT: Alright, only took half an hour.
What was breaking it was the PTE change of "commander && commander.UnitSpec && inventory.addUnits([commander.UnitSpec]);" -> "commander && inventory.addUnits([commander]);" in /ui/main/game/galactic_war/cards/gwc_start.js. Fixed that and now it's working properly. And I actually mean properly! It's not crashing when new units are firing or anything! This is really, really exciting. Galactic Annihilation will be the first rebalance mod to have Galactic War support.
EDIT: Turns out I was wrong. While light missile tower wasn't crashing, tank_attack and bot_mortar were. Odd. :/
@mkrater Okay, so download this (Newly updated): https://github.com/Stuart1998/Galactic-Annihilation/raw/master/REL/Client/GalacticWarTest.zip Then start a galactic war, build a vehicle factory, and then build a striker tank (next to the bolo/ant) and have it shoot something. Enemy, wreckage, tree, doesn't matter. Just get it to shoot something and then have someone tell me why it's crashing.
Okay, I think I've isolated the repro case to "The model name is different from the unit.json name", eg land_scout.json's model is veh_scout.papa. @mkrater @jables @Sorian @masterdigital @pinbender @otheruberentsasithinkofthemifyouaren'thereyou'reunloved
