[REL/WIP] rEventHandler - A PA engine process event framework

I don't want to stop you from doing stuff, don't worry. Just trying to understand if this can help me with the stuff I do

This mod appears to be causing double dispatch of server_state events (at least) I'll investigate further after I patch Linger to ignore the second game_over state.

Looks like both the mods process_message and the common.js process_message are firing; I assume this applies to all engine events. Perhaps the Coherent version upgrade changed it from single dispatch to multi-dispatch? The upside is that now it should be a lot easier to make additional handlers without having to reproduce the game's own handler pipeline.

might be, I think it could be the scene changes. I will take a look at this. Need to shovel in an update anyway

Ok, i think i figured it out- it does not duplicate handlers before the end of live_game it seems,*. I will fix this in the next update.

*nvm, turns out to be more annoying than that

** this is fixed now

This mod (v1.2) makes the chat box never close on 68331.

Yeah, if you have the mod enabled the chat box won't close which means you have to use the task manager to close the program. It is pretty annoying.

I think it was ko deferred keeping the chat box open but for me I can press enter to tell it to close and then it disappears when I drag the map around.

This mod seems to be broken i have the exact same problem.

Please consider depatching callbacks with a timeout to allow for rescheduling.

E.g.:

PHP:

// Looks like this now
callback(payload);
// But should look more like this
setTimeout(function() {
    callback(payload);
}, 0);

Why? Because that way you make sure to return control ASAP. Don't worry about overhead, the JS event queue is specifically designed for doing such a thing. Also allows Uber to tweak the priorities if they should ever feel like messing with the event queues of the JS engine used.

I *think* Coherent might even be so smart to prioritize mouse and keyboard events over user generated events by default which is just what you want as it keeps the system responsive for critical, synchronous tasks, but I'm not positive about that.

You'd horribly break quite a lot of code by that kind of thing.

Just made a pull on the repo, fixed a bunch of syntax errors. If its gona be a standard, it should be a good one


Sidenote:
Think about not using

Code:

with(foo){}

This is generally considered bad practice. I would instead just do

Code:

var self = this;
self.foo(baz).bar(bek);

So pretty much use 'var self = this;' instead. It also seams to be the standard in the PA files so maybe follow that for consistency

If it seams like I'm just picking on it, I'm not. I'm just trying to be helpful.