[REL] Commander Health Display v2.7.4 [61250]

Yep, my bad. I only set the position variables after a drag. It didn't occur to me that might not be sufficient

tried again. not only does it not show up but neither do the strat isons.

Does the debugger show any errors? If you aren't sure how to check, with PA running, do the following

1. Run PA\Coherent\Debugger\Win64\Debugger.exe (or Win32 as appropriate)
2. Click "Go"
3. Click the first item
4. Look at the bottom right for a red/yellow icon, and click it if present

Let me know any error messages that appear. Also, double-check ui_mods_list.js to ensure they've been enabled properly (if not, remove the file and let PAMM rebuild it).

yellow icon says 7
this is the result.

It doesn't look like you've enabled commander HP?

Let me know if you fixed this , I will enable it then for hotbuild preview

So I've got a fix ready, but I've found a bug in PAMM to do with priority ordering of mods, and if I release the mod before fixing that it will cause all sorts of annoyance, so it wont be until tonight

The bug with the Floating Framework is easily worked around though, as soon as you move the frame even once it won't occur again.

No hurries, code is ready in hotbuild2 just need to uncomment it.
Will update tomorrow then , cause now I'm going to play with this cool build.

what? I did, I even checked the modlist files, rCommanderHP shows up everywhere it should.

I'm getting same problem as Tatsu I'm guessing we have a mod that is conflicting.

Edit: Nope also done clean with no other mods apart from floating framework and settings manager

no look earlyer in the thread, I tried it with a freash repatch and mod folder completely emptied out (PAMM creates the modlist file)

The log you attached doesn't show the rCommanderHP.js file being loaded at all. Can you double-check your ui_mod_list.js?

Edit: Also check the UI tab in Settings, and let me know if you see the show/hide option for the Commander HP bar

i did both it's there.

I can't replicate this issue

Actually it happens to me as well. I have both the floating frames and the settings mod installed, but the health display doesn't appear in either settings or during the game.
I started up the debugger and when I go to the settings in PA it throws

Code:

Uncaught TypeError: Object #<SettingsViewModel> has no method 'addSetting_DropDown'

Also it explicitly says that it loads rFloatFrame.js, rSettingsManager_global.js and rCommanderHP_settings.js
There are no errors when in live_game though. It just doesn't show even though the debugger claims it loaded.
(Oh, this is under Linux if that matters)

The error message is because it's missing rSettingsManager.js, which should also be loaded on the settings screen - can you confirm it's definitely not loaded? What about in ui_mods_list.js?

@tatsujb, @zaphodx & @DeathByDenim, Try these:

I tried the files on my office computer. The commander health now does show in live_game, but still not in settings. However, when I install the old mods from pamm again, it still works...? Maybe it's something specific to my home computer. I'll try that later. At home I do have a slightly lower resolution, 1600 x 900 instead of 1680 x 1050, but that shouldn't really matter, eh?

I didn't see rSettingsManager.js in the Debugger at home though, but I'll check later, because I can't get the Debugger to work at work (seems to depend on an older version of PA). ui_mods_list.js was definitely loaded, because rModsList did work for example. Also rSettingsManager.js is present in ui_mods_list.js under settings:

Code:

    'settings': [
        /* PAMM BEGIN (do not edit below) */
        /* Settings Manager */
        '../../mods/rSettingsManager/rSettingsManager.js',
        '../../mods/rSettingsManager/rSettingsManager.css',
        /* Commander Health Display */
        '../../mods/rCommanderHP/rCommanderHP_settings.js',
        /* Floating Framework */
        '../../mods/rFloatFrame/rFloatFrame_settings.js'
        /* PAMM END (do not edit above) */
    ],

Works for me now. I have settings menu too.

Ah, that's good to hear. I found a whole bunch of edge case bugs. The difficulty working with anything to do with settings is as soon as it works once, it tends to keep working, even if you break the part that originally set the setting. This is why it would continue to work after rolling back to the old version.

I also (embarassingly) failed to use my own mod correctly and didn't call initialSettingValue() to provide a default value for when to show the commander HP bar before using it . Not sure why rSettingsManager.js isn't working for you though.

Version 2.7.1 Released

• Bugfix - Initial value of setting "commander_hp_display_show" not set.
• Bugfix - Default value for preferredCommander now included

Please also update the Floating Framework mod.